| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some dead code in functioncmds.c |
| Date: | 2009-10-30 16:17:24 |
| Message-ID: | 162867790910300917m321dbfd7udaa440b293be872@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2009/10/30 Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>:
> Pavel Stehule wrote:
>> else
>> {
>> ereport(ERROR,
>> (errcode(ERRCODE_INVALID_FUNCTION_DEFINITION),
>> errmsg("function result type must be specified")));
>> /* Alternative possibility: default to RETURNS VOID */
>>
>> /* WHY FOLOWING LINES? */
>> prorettype = VOIDOID;
>> returnsSet = false;
>> }
>
> To keep the compiler quiet about using the variables uninitialized. The
> compiler doesn't know that ereport(ERROR) never returns.
>
Should be similar code little bit commented?
Pavel
> --
> Heikki Linnakangas
> EnterpriseDB http://www.enterprisedb.com
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hans-Juergen Schoenig -- PostgreSQL | 2009-10-30 16:19:03 | draft RFC: concept for partial, wal-based replication |
| Previous Message | Jeff Davis | 2009-10-30 16:12:40 | Re: Syntax for partitioning |