From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Jeff Davis <pgsql(at)j-davis(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: Patch for 8.5, transformationHook |
Date: | 2009-08-10 13:52:35 |
Message-ID: | 162867790908100652p3084ef49ne905343079777bfc@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2009/8/10 Peter Eisentraut <peter_e(at)gmx(dot)net>:
> On Sunday 09 August 2009 05:21:48 Jeff Davis wrote:
>> * If the hook can implement XML, should we refactor the XML support (and
>> COALESCE, etc.) to use the hook for the sake of consistency? If the hook
>> is not good enough for those features, that might indicate a problem.
>
> Well, for 8.4, I proposed to rewrite xmlconcat, which is currently part of
> that hardcoded XML support, into a variadic function. That was shot down for
> some unclear backwards compatibility reason. (I guess, someone might have
> created their own xmlconcat function in a public schema and would now be
> surprised that it's actually callable?!?) With that in mind, what chances of
> success will a plan have that proposes to reimplement a bunch of core
> functionality like COALESCE in user space?
>
> Another example that was mentioned during PGCon and that these hooks may or
> may not be useful for is somehow de-hardcoding various SQL-standard
> parentheses-less functions such as current_timestamp (thus opening the door
> for implementing Oracle's sysdate in userspace), but it's again unclear to me
> whether that would not be objected to if those functions became subject to the
> schema search path.
>
This patch doesn't help with it. But I thing so we will have other
hook in transformation - column name. This hook will serve for
detection plpgsql variables in SQL statement. And this hook should be
used for some parentheses-less functions.
regards
Pavel
>
From | Date | Subject | |
---|---|---|---|
Next Message | wader2 | 2009-08-10 14:10:19 | Re: BUG #4961: pg_standby.exe crashes with no args |
Previous Message | Peter Eisentraut | 2009-08-10 13:42:21 | Re: Patch for 8.5, transformationHook |