Re: Proposal to add page headers to SLRU pages

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: "Li, Yong" <yoli(at)ebay(dot)com>, "Shyrabokau, Anton" <antons(at)ebay(dot)com>, "Debnath, Shawn" <sdn(at)ebay(dot)com>
Subject: Re: Proposal to add page headers to SLRU pages
Date: 2023-12-07 17:32:20
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

<br /><br /><br />07.12.2023, 19:17, "Aleksander Alekseev" &lt;aleksander(at)timescale(dot)com&gt;:<br /><blockquote><p>Hi,<br /><br /></p><blockquote class="210e7a848e8fcb45wmi-quote"> +1 to the idea to protect SLRUs from corruption. I'm slightly leaning towards the idea of separating checksums from data pages, but anyway this checksums are better than no checksums.<br /><br /> On 7 Dec 2023, at 10:06, Li, Yong &lt;<a href="mailto:yoli(at)ebay(dot)com">yoli(at)ebay(dot)com</a>&gt; wrote:<br /><br /> I am still working on patching the pg_upgrade. Just love to hear your thoughts on the idea and the current patch.<br /><br /> FWIW you can take upgrade code from this patch [0] doing all the same stuff :)<br /></blockquote><p><br />Sounds like a half-measure to me. If we really want to go down this<br />rabbit hole IMO SLRU should be moved to shared buffers as proposed<br />elsewhere [1].<br /></p></blockquote>Thread that I cited stopped in 2018 for this exact reason. 5 years ago. Is this argument still valid?<div>Meanwhile checksums of buffer pages also reside on a page :)</div><div><br /></div><div>Best regards, Andrey Borodin.</div>

Attachment Content-Type Size
unknown_filename text/html 1.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-12-07 17:34:00 Re: Remove MSVC scripts from the tree
Previous Message Robert Haas 2023-12-07 17:19:24 Re: remaining sql/json patches