[PATCH] use separate PartitionedRelOptions structure to store partitioned table options

From: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Nikolay Shaplov <dhyan(at)nataraj(dot)su>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dent John <denty(at)qqdd(dot)eu>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: [PATCH] use separate PartitionedRelOptions structure to store partitioned table options
Date: 2019-10-06 12:47:46
Message-ID: 1627387.Qykg9O6zpu@x200m
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


This message is follow up to the "Get rid of the StdRdOptions" patch thread:

I've split patch into even smaller parts and commitfest want each patch in
separate thread. So it is new thread.

The idea of this patch is following: If you read the code, partitioned tables
do not have any options (you will not find RELOPT_KIND_PARTITIONED in
boolRelOpts, intRelOpts, realRelOpts, stringRelOpts and enumRelOpts in
reloption.c), but it uses StdRdOptions to store them (these no options).

If partitioned table is to have it's own option set (even if it is empty now)
it would be better to save it into separate structure, like it is done for
Views, not adding them to StdRdOptions, like current code hints to do.

So in this patch I am creating a structure that would store partitioned table
options (it is empty for now as there are no options for this relation kind),
and all other code that would use this structure as soon as the first option

I think it is bad idea to suggest option adder to ad it to StdRdOption, we
already have a big mess there. Better if he add it to an new empty structure.

Software Developer: https://www.upwork.com/freelancers/~014a87e140ff02c0da
Body-oriented Therapist: https://vk.com/nataraj_rebalancing (Russian)

Attachment Content-Type Size
use-empty-structure-for-partitioned-options_v1.diff text/x-patch 4.2 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Shaplov 2019-10-06 13:45:27 Re: [PATCH] Do not use StdRdOptions in Access Methods
Previous Message Amit Kapila 2019-10-06 10:59:27 Re: [HACKERS] Block level parallel vacuum