Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> writes: > Suggested patch (first of many, I hope) renames `md5Salt` to more > general `pwsalt`. > Does it sound reasonable?
I'm dubious. The main problem with supposing that port->md5Salt can serve other purposes is its fixed size. I think you're likely going to have to change that representation at some point (eg make it a separately-palloc'd field). My inclination would be to do the field renaming at the same time you change the representation, since that provides a convenient way to ensure you've caught every place that has to change.