From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Cleanup - Removal of unused function parameter from CopyReadBinaryAttribute |
Date: | 2020-06-19 03:48:37 |
Message-ID: | 1623305.1592538517@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Thu, Jun 18, 2020 at 10:05 PM Fujii Masao
> <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>> column_no was used for that purpose in the past, but commit 0e319c7ad7
>> changed that.
> Yeah, but not sure why? By looking at the commit message and change
> it is difficult to say why it has been removed? Tom has made that
> change but I don't think he would remember it, in any case, adding him
> in the email to see if he remembers anything related to it.
Hm, no, that commit is nearly old enough to vote :-(
However, I dug around in the archives, and I found what seems to be
the relevant pghackers thread:
Looking at that, I think I concluded that these error cases are not useful
indications of problems within the specific column's data, but most likely
indicate corruption at the level of the overall COPY line format; ergo the
line-level context display is sufficient. You could quibble with that
conclusion of course, but if you agree with it, then the column_no
parameter is useless here. I probably just failed to notice at the time
that the parameter was otherwise unused, else I would have removed it.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2020-06-19 03:56:16 | Re: POC and rebased patch for CSN based snapshots |
Previous Message | Amit Kapila | 2020-06-19 03:39:03 | Re: min_safe_lsn column in pg_replication_slots view |