Re: [PATCH] expand the units that pg_size_pretty supports on output

From: Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: David Christensen <david(at)pgguru(dot)net>
Subject: Re: [PATCH] expand the units that pg_size_pretty supports on output
Date: 2021-05-30 12:38:36
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested

Hi David,

I was reviewing this patch and the compilation failed with following error on CentOS 7.

dbsize.c: In function ‘pg_size_bytes’:
dbsize.c:808:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
const int unit_count = 9; /* sizeof units table */
dbsize.c:809:3: error: variable length array ‘units’ is used [-Werror=vla]
const char *units[unit_count] = {

I believe "unit_count" ought to be a #define here.


The new status of this patch is: Waiting on Author

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2021-05-30 13:14:33 Re: GISTSTATE is too large
Previous Message Laurenz Albe 2021-05-30 11:19:55 Re: [PATCH] More docs on what to do and not do in extension code