| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Provide support for trailing commas |
| Date: | 2026-01-06 20:48:59 |
| Message-ID: | 1619826.1767732539@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greg Sabino Mullane <htamfids(at)gmail(dot)com> writes:
> Happy New Year! Please find attached a patch to provide comprehensive
> trailing comma support, where we allow (when possible) a comma that does
> NOT come before the next item in a list. To wit:
> SELECT 1,2,3, FROM pg_class, ORDER BY greatest(relpages,1,);
Did we not discuss and reject this very idea in the past?
A quick search finds [1][2], and there may be more threads.
> This is not as trivial a task as it seems, as those who have dabbled with
> our parser (or parsers in general) may suspect.
Indeed. I think it carries substantial risk of creating large parsing
problems down the road, when we try to integrate whatever random
syntax the SQL committee comes up with next. And frankly, I don't
agree that it'd be beneficial.
regards, tom lane
[1] https://www.postgresql.org/message-id/flat/20140928114246.GA22150%40artax.karlin.mff.cuni.cz
[2] https://www.postgresql.org/message-id/flat/0368c60f-abe2-4f5f-972d-7cd1e6db2382%40gmail.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vincent Veyron | 2026-01-06 21:05:04 | Re: pg18 bug? SELECT query doesn't work |
| Previous Message | Greg Sabino Mullane | 2026-01-06 20:35:38 | [PATCH] Provide support for trailing commas |