| From: | ahsan hadi <ahsan(dot)hadi(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Lætitia AVROT <laetitia(dot)avrot(at)gmail(dot)com> |
| Subject: | Re: pg_dump new feature: exporting functions only. Bad or good idea ? |
| Date: | 2021-04-29 11:46:48 |
| Message-ID: | 161969680810.1148.13492649818376956665.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: not tested
Few minor comments :
- The latest patch has some hunk failures
- Regression with master has many failures with/without the patch, it is difficult to tell if the patch is causing any failures.
- This is probably intended behaviour that --functions-only switch is also dumping stored procedures?
- If i create a procedure with
LANGUAGE plpgsql
SECURITY INVOKER
It is not including "SECURITY INVOKER" in the dump. That's probably because INVOKER is default security rights.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-04-29 11:53:57 | Re: [BUG] "FailedAssertion" reported when streaming in logical replication |
| Previous Message | Bharath Rupireddy | 2021-04-29 11:06:55 | Re: function for testing that causes the backend to terminate |