From: | Cary Huang <cary(dot)huang(at)highgo(dot)ca> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Cc: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
Subject: | Re: [PATCH] Add --create-only option to pg_dump/pg_dumpall |
Date: | 2021-03-29 17:59:00 |
Message-ID: | 161704074015.1180.15614499301846689907.pgcf@coridan.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: not tested
Hi
I have tried the patch and the new option is able to control the contents of pg_dump outputs to include only create db related commands. I also agree that the option name is a little misleading to the user so I would suggest instead of using "create-only", you can say something maybe like "createdb-only" because this option only applies to CREATE DATABASE related commands, not CREATE TABLE or other objects. In the help menu, you can then elaborate more that this option "dump only the commands related to create database like ALTER, GRANT..etc"
Cary Huang
-------------
HighGo Software Inc. (Canada)
cary(dot)huang(at)highgo(dot)ca
www.highgo.ca
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2021-03-29 18:36:24 | Re: Merging statistics from children instead of re-sampling everything |
Previous Message | Joel Jacobson | 2021-03-29 17:55:49 | Re: Idea: Avoid JOINs by using path expressions to follow FKs |