| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: Log query parameters for terminated execute |
| Date: | 2018-07-23 10:05:51 |
| Message-ID: | 16162831532340351@sas1-640e2cc17194.qloud-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
Thank you for review!
Well, i can miss some cases. I'm not sure about overall design of this patch. Is acceptable add errdetail_params to statement_timeout ereport in such way?
After shutdown signal we must be in aborted state, so we mustn't call user-defined I/O functions. (quotation from comment to errdetail_params in src/backend/tcop/postgres.c ). It seems i can not fix it with current design.
> ERROR: canceling statement due to lock timeout at character 13
Hm, "at character"? How can we get this message? I found only "canceling statement due to lock timeout" (without "at character") ereport in src/backend/tcop/postgres.c
Maybe try .. catch in parse state, not in execute?
regards, Sergei
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2018-07-23 10:06:58 | Re: Possible performance regression in version 10.1 with pgbench read-write tests. |
| Previous Message | Ashutosh Bapat | 2018-07-23 09:38:41 | Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. |