From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Joshua Drake <jd(at)commandprompt(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
Subject: | Re: Mail thread references in commits |
Date: | 2016-11-18 21:06:18 |
Message-ID: | 1614.1479503178@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Nov 17, 2016 at 10:43 PM, Joshua Drake <jd(at)commandprompt(dot)com> wrote:
>> Why not hash the URL? Something like:
>> Http://postgresopen.org/archive/743257890976432
> I suggested that upthread...
Don't like the hashing idea because that would be useless for searching,
eg, one's own local mail archives. Also, if you are looking at a message
in your own mail store when composing a commit message (which I generally
am, don't know about other committers) how are you going to get the hash?
I think it's important to have the message-ID in cleartext.
AFAICS the proposal here is to go from, eg,
Discussion: <CAF4Au4w6rrH_j1bvVhzpOsRiHCog7sGJ3LSX0tY8ZdwhHT88LQ(at)mail(dot)gmail(dot)com>
to
Discussion: https://www.postgresql.org/message-id/CAF4Au4w6rrH_j1bvVhzpOsRiHCog7sGJ3LSX0tY8ZdwhHT88LQ@mail.gmail.com
which is annoying, but the line was overlength already. Maybe we could
drop the Discussion: prefix and just write a URL:
That's still overlength for gmail message-IDs, though, so I'm not sure
it's worth losing the label for.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-11-18 21:11:57 | Re: Fun fact about autovacuum and orphan temp tables |
Previous Message | Alvaro Herrera | 2016-11-18 21:05:55 | Re: [RFC] Should we fix postmaster to avoid slow shutdown? |