| From: | Cary Huang <cary(dot)huang(at)highgo(dot)ca> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Japin Li <japinli(at)hotmail(dot)com> |
| Subject: | Re: Fix typo about WalSndPrepareWrite |
| Date: | 2021-02-17 18:13:57 |
| Message-ID: | 161358563718.24325.3410339738199469749.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
Hi,
thanks for the patch, however I don't think it is a typo. The comment indicates a technique that is used throughout many functions in walsender.c, which is to fill the send-timestamp as late as possible so it is more accurate. This is done by first reserving a spot in the write stream, write the actual data, and then finally write the current timestamp to the reserved spot. This technique is used in WalSndWriteData() and also XLogSendPhysical()... so really it doesn't matter which function name to put in the comment.
thank you!
-----------
Cary Huang
HighGo Software (Canada)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2021-02-17 18:34:36 | cryptohash: missing locking functions for OpenSSL <= 1.0.2? |
| Previous Message | Justin Pryzby | 2021-02-17 16:24:37 | Re: progress reporting for partitioned REINDEX |