Re: {CREATE INDEX, REINDEX} CONCURRENTLY improvements

From: Hamid Akhtar <hamid(dot)akhtar(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: {CREATE INDEX, REINDEX} CONCURRENTLY improvements
Date: 2020-12-08 08:17:25
Message-ID: 160741544562.1176.7026067125938201934.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested

The patch looks good to me. With regards to the code comments, I had pretty similar concerns as already raised by Dmitry; and those have already been answered by you. So this patch is good to go from my side once you have updated the comments per your last email.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ajin Cherian 2020-12-08 08:31:15 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Li Japin 2020-12-08 07:45:52 Re: About to add WAL write/fsync statistics to pg_stat_wal view