From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
Cc: | "emre(at)hasegeli(dot)com" <emre(at)hasegeli(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
Subject: | Re: regexp_match() returning text |
Date: | 2016-08-17 22:37:42 |
Message-ID: | 1607.1471473462@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
"David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> I didn't compile either patch but given the scope and complexity I'd say it
> is ready for committer without that confirmed. Tom usually touches the
> regexp code and I'm pretty sure he'll look at this with an eye no one else
> has. Though I wouldn't expect anything until work on 10 begins in earnest.
Pushed with some cosmetic adjustments to the code and rather more
extensive work on the documentation.
I did *not* push the hunk in citext.sgml, since that was alleging support
that doesn't actually exist in this patch. To make this work for citext,
we need to add wrapper functions similar to citext's wrappers for
regexp_matches. And that in turn means a citext extension version bump,
which makes it more notationally tedious than I felt like dealing with
today. I'm bouncing that requirement back to you to produce a separate
patch for.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2016-08-17 23:12:09 | CLUSTER, reform_and_rewrite_tuple(), and parallelism |
Previous Message | David Steele | 2016-08-17 22:25:04 | Re: PATCH: Exclude additional directories in pg_basebackup |