From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: do we want to gitignore regression-test-failure files? |
Date: | 2010-09-26 19:45:32 |
Message-ID: | 16035.1285530332@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Seems like it's probably a good idea, but I wanted to double-check
> that no one has a different thought.
-1. If the lack of an ignore causes a problem for you, it indicates
that you're trying to commit code that fails the regression tests.
Is it really a good idea to let that happen without any manual cleanup?
I'm a bit surprised that you think this is a good idea while not
favoring having, say, *.rej in the ignore configuration.
I'd be inclined to put this in the category of things that people can
ignore in their personal configurations if they think it's a good idea.
If we were going to do this, we'd need it in a lot more places than
just src/test/regress/ --- I think it'd really need to be a global
ignore.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-09-26 19:50:06 | Re: Patch: Extend NOT NULL representation to pg_constraint |
Previous Message | Gurjeet Singh | 2010-09-26 19:45:28 | Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog. |