darcy(at)druid(dot)net (D'Arcy J.M. Cain) writes:
>> heap_formtuple is for constructing a tuple from scratch. It sounds like
>> you should be using heap_modifytuple instead.
> But I am using SPI_modifytuple(). The rest came from tracing that
> function.
Hm. Looks like the author of SPI_modifytuple didn't realize he could
use heap_modifytuple :-(. But he is correctly extracting the old data.
I don't see anything wrong there, assuming that you are passing a
relation descriptor that matches the original tuple.
regards, tom lane