| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Avoid duplicate file references in backend .pot file |
| Date: | 2026-11-02 10:35:12 |
| Message-ID: | 15b90fcc-cf6e-492d-82a4-29739b2c040f@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The list of files for the backend's message catalog is collected with
find, which also lists symlinks, namely the generated files that are
linked from src/include/utils/ to src/backend/utils/ (such as
guc_tables.inc.c) and the port/pg_sema.c and port/pg_shmem.c links
created by configure. Since the link targets are found under their real
names as well, xgettext processed those files twice, resulting in
duplicate "#:" references like
#: ../include/utils/guc_tables.inc.c:410 utils/guc_tables.inc.c:410
This is an old problem, but the introduction of guc_tables.inc.c in PG19
has made it much more noticeable.
I propose the attached patch to fix this by restricting find to regular
files.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Avoid-duplicate-file-references-in-backend-.pot-file.patch | text/plain | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-11-02 10:49:18 | Re: Add counted_by attribute |
| Previous Message | Álvaro Herrera | 2026-11-02 10:34:04 | Re: PostgreSQL 19 GA press release draft |