| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Christian Ullrich <chris(at)chrullrich(dot)de> |
| Cc: | pgsql-interfaces(at)postgresql(dot)org |
| Subject: | Re: libpq++ on Windows |
| Date: | 2001-07-02 04:21:45 |
| Message-ID: | 1598.994047705@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-interfaces |
Christian Ullrich <chris(at)chrullrich(dot)de> writes:
> * Peter Eisentraut wrote on Sunday, 2001-07-01:
>> Why not put the addition to config.h.in into config.h.win32? When doing a
>> native Win32 build config.h.in isn't used anyway.
> Because the '#define DLLAPI' in config.h.in -- from which the
> config.h for Unix and Cygwin/Win32 builds is generated -- is
> necessary to make the compiler happy about the modifications
> to the class declarations.
config.h.in is absolutely NOT the right place for platform-specific
defines.
I'd put this in the same category as DLLIMPORT, which is in c.h
(and just as ugly an example of Microsoft cultural imperialism,
but I suppose there's no point in arguing about it).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christian Ullrich | 2001-07-02 14:57:02 | Re: libpq++ on Windows |
| Previous Message | Ernesto A. Lira Castro | 2001-07-02 03:03:53 | Security |