| From: | Georgios Kokolatos <gkokolatos(at)protonmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Subject: | Re: Using Valgrind to detect faulty buffer accesses (no pin or buffer content lock held) |
| Date: | 2020-07-06 08:34:56 |
| Message-ID: | 159402449672.1150.17670816824105739624.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
As a general overview, the series of patches in the mail thread do match their description. The addition of the stricter, explicit use of instrumentation does improve the design as the distinction of the use cases requiring a pin or a lock is made more clear. The added commentary is descriptive and appears grammatically correct, at least to a non native speaker.
Unfortunately though, the two bug fixes do not seem to apply.
Also, there is a small issue regarding the process, not the content of the patches. In CF app there is a latest attachment (v3-0002-Add-nbtree-Valgrind-buffer-lock-checks.patch) which does not appear in the mail thread. Before changing the status, I will kindly ask for the complete latest series that applies in the mail thread.
The new status of this patch is: Waiting on Author
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey V. Lepikhov | 2020-07-06 08:46:23 | Re: Asymmetric partition-wise JOIN |
| Previous Message | kato-sho@fujitsu.com | 2020-07-06 08:25:37 | Performing partition pruning using row value |