Re: Tightening up allowed custom GUC names

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Tightening up allowed custom GUC names
Date: 2021-04-07 15:23:34
Message-ID: 1593065.1617809014@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> We can't allow '-', for the specific reason that it won't work as a -c
> argument (thanks to -c's translation of '-' to '_'). The whole point here
> is to prevent corner cases like that. ':' would be all right, but I think
> it's a lot simpler to explain and a lot harder to break in future if we
> just say that the names have to be valid identifiers.

Hearing no further comments, I pushed the more restrictive version.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2021-04-07 15:27:43 Re: WIP: WAL prefetch (another approach)
Previous Message Pavel Borisov 2021-04-07 15:23:03 Re: [PATCH] Improve treatment of page special and page header alignment during page init.