| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tv(at)fuzzy(dot)cz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: SlabCheck leaks memory into TopMemoryContext |
| Date: | 2020-01-16 20:15:41 |
| Message-ID: | 15906.1579205741@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
> I think the one possible argument against this approach might be that it
> adds a field to the struct, so if you have an extension using a Slab
> context, it'll break if you don't rebuild it. But that only matters if
> we want to backpatch it (which I think is not the plan) and with memory
> context checking enabled (which does not apply to regular packages).
Huh? That struct is private in slab.c, no? Any outside code relying
on its contents deserves to break.
I do think we ought to back-patch this, given the horrible results
Andres showed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2020-01-16 20:21:28 | Re: SlabCheck leaks memory into TopMemoryContext |
| Previous Message | Tom Lane | 2020-01-16 20:11:15 | Re: making the backend's json parser work in frontend code |