| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Vaishnavi Prabakaran <vaishnaviprabakaran(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall |
| Date: | 2018-01-19 14:45:41 |
| Message-ID: | 15873.1516373141@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Jan 18, 2018 at 6:35 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> If we did it like that, the rationale for an actual --set-db-properties
>> switch would vanish, at least so far as pg_dumpall is concerned -- we
>> could just make all that behavior an integral part of --create. And
>> this wouldn't need to be conditional on getting ALTER DATABASE
>> CURRENT_DATABASE done.
> Unfortunately, I have a feeling that --set-db-properties might not be
> the only thing that would vanish. I think users are accustomed by now
> to the idea that if you restore into an existing database, the
> existing contents are preserved and the new stuff from the dump is
> added (possibly with some errors and messiness). With this design,
> the existing database contents will instead vanish, and that is
> probably going to make somebody unhappy.
Well, we could say that the properties of template1 and postgres
are only restored if you use --clean.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-01-19 14:52:00 | Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall |
| Previous Message | Robert Haas | 2018-01-19 14:42:25 | Re: [HACKERS][PATCH] Applying PMDK to WAL operations for persistent memory |