| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Less than ideal error reporting in pg_stat_statements |
| Date: | 2015-09-22 23:38:05 |
| Message-ID: | 15837.1442965085@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> On 23 September 2015 at 10:16, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> wrote:
>>> Attached patch fixes, though I'm not sure if %lld is portable or not.
It is not.
> I think you could probably use INT64_FORMAT,
Not in a message you expect to be translatable.
There are ways around that, but TBH I do not think that including the file
size in the errdetail is valuable enough to be worth the trouble. I'd
just leave it out. "insufficient memory to load statement file" seems
quite enough.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-09-22 23:40:25 | Re: Less than ideal error reporting in pg_stat_statements |
| Previous Message | Jim Nasby | 2015-09-22 23:27:13 | Re: Less than ideal error reporting in pg_stat_statements |