Re: [HACKERS] Deadlock with pg_dump?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Chris Campbell <chris(at)bignerdranch(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Deadlock with pg_dump?
Date: 2007-03-01 05:45:54
Message-ID: 15832.1172727954@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> I have coded up the following patch which places LOG just above ERROR in
> log_min_error_statement.

LOG_NO_STATEMENT? What *are* you thinking? The kindest word I can find
for this is "baroque".

What I had in mind was a one-line patch:

if (edata->elevel >= log_min_error_statement && debug_query_string != NULL)

becomes

if (is_log_level_output(edata->elevel, log_min_error_statement) && debug_query_string != NULL)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-03-01 05:50:58 Re: Packed short varlenas, what next?
Previous Message Mageshwaran 2007-03-01 05:26:31 Re: POSTGRES WAL

Browse pgsql-patches by date

  From Date Subject
Next Message Patric Bechtel 2007-03-01 06:03:28 Re: Numeric patch to add special-case representations for < 8 bytes
Previous Message Michael Glaesemann 2007-03-01 04:41:45 Re: Numeric patch to add special-case representations for < 8 bytes