Re[4]: bool_plperl transform

From: Ivan Panchenko <wao(at)mail(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re[4]: bool_plperl transform
Date: 2020-03-02 00:01:40
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Thanks, Tom.
I think now it should build, please find the fixed patch attached.
I had no possibility to check it on Windows now, but the relevant changes in are done, so I hope it should work.
The documentation changes are also included in the same patch.
>Понедельник, 2 марта 2020, 0:14 +03:00 от Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:

>=?UTF-8?B?V2Fv?= < wao(at)mail(dot)ru > writes:
>> Please find the full patch attached.
>The cfbot shows this failing to build on Windows:
>I believe that's a build without plperl, so what it's probably telling
>you is that needs to be taught to build this module
>conditionally, as it already does for hstore_plperl and jsonb_plperl.
>Also, while the Linux build is passing, I can't find that it is actually
>compiling or testing bool_plperl anywhere:
>This is likely because you didn't add it to contrib/Makefile.
>In general, I'd suggest grepping for references to hstore_plperl
>or jsonb_plperl, and making sure that bool_plperl gets added where
>I rather imagine you need a .gitignore file, as well.
>You're also going to have to provide some documentation, because
>I don't see any in the patch.
>regards, tom lane

Attachment Content-Type Size
bool_plperl_transform_v3.patch application/octet-stream 16.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-03-02 02:06:00 Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions?
Previous Message Chris Bandy 2020-03-01 23:51:24 Re: [PATCH] Add schema and table names to partition error