From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Serguei Mokhov <mokhov(at)cs(dot)concordia(dot)ca>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: more adequate usage msg: pg_controldata.diff |
Date: | 2003-01-09 22:06:23 |
Message-ID: | 15822.1042149983@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Bruce Momjian writes:
>> Patch applied, with slight adjustment. New output is:
> I explained in my last message that this patch is wrong. Please revert
> it. (DATADIR is not an option and therefore it shouldn't be listed in the
> options list.)
Actually, it is optional for pg_controldata. The usage message is
technically correct as it stands because pg_controldata accepts at most
one argument (either --help, --version, or a DATADIR name).
At some point in the future we might alter the program so that it can
take some switches as well as a DATADIR name, and at that time the
distinction between switches and DATADIR would become significant.
But as of today, a usage message like
pg_controldata [options] [DATADIR]
would actually be wrong, so I'm not sure what to put instead.
I agree with Peter's objection in principle, but given that the program
has such a limited commandline syntax, I can't find a hard reason to do
otherwise than Bruce did.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2003-01-09 23:30:59 | Re: more adequate usage msg: pg_controldata.diff |
Previous Message | Bruce Momjian | 2003-01-09 21:52:43 | Re: Docs for service file |