Re: pgsql: pgbench: Add a real expression syntax to \set

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Mar 2, 2015 at 2:38 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The makefile changes in this do not look right to me. Files that are
>> meant to be shipped in the tarball should be removed by make
>> maintainer-clean, not an ordinary "make clean" which is what the committed
>> patch appears to do. Otherwise, a tarball user without bison installed
>> would be cut off at the knees if he did "make clean" or "make distclean";
>> but those operations are not supposed to remove files that were in the
>> tarball.

> Hmm, yeah. Also, it appears that the exprscan.h file doesn't actually
> get (or need to be) generated here. So I think we need something like
> the attached.

Looks OK to me.

regards, tom lane