| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ecpg_config.h symbol missing with meson |
| Date: | 2024-04-17 16:15:00 |
| Message-ID: | 1580077.1713370500@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> I checked the generated ecpg_config.h with make and meson, and the meson
> one is missing
> #define HAVE_LONG_LONG_INT 1
> This is obviously quite uninteresting, since that is required by C99.
> But it would be more satisfactory if we didn't have discrepancies like
> that. Note that we also kept ENABLE_THREAD_SAFETY in ecpg_config.h for
> compatibility.
> ...
> Alternatively, we could remove the symbol from the make side.
Think I'd vote for removing it, since we use it nowhere.
The ENABLE_THREAD_SAFETY precedent feels a little bit different,
since there's not the C99-requires-the-feature angle.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2024-04-17 16:37:07 | Re: Parallel CREATE INDEX for BRIN indexes |
| Previous Message | Pavel Borisov | 2024-04-17 15:41:10 | Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. |