Re: Ignore tablespace ACLs when ignoring schema ACLs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Ignore tablespace ACLs when ignoring schema ACLs
Date: 2017-02-05 18:48:09
Message-ID: 15798.1486320489@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah Misch <noah(at)leadboat(dot)com> writes:
> On Sun, Feb 05, 2017 at 12:46:41PM -0500, Tom Lane wrote:
>> Is there any likely use-case for providing separate control flags for the
>> two permission checks? That would require an API change for DefineIndex,
>> making this considerably more invasive, so I'm not pushing for it ---
>> just think it's worth asking the question before proceeding.

> Good question. I can't think of one.

Yeah, after some reflection I agree. Basically what we want for the ALTER
TABLE scenario is "ignore *all* permissions checks"; if somebody adds some
other check here in future, it probably also ought to be skipped during
a rebuild. So a single bool ought to be fine.

Are you intending to back-patch this? It seems like a bug fix --- but not
a very high-priority one, so at this point maybe it should wait till after
the release wraps.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2017-02-05 18:56:03 Re: Ignore tablespace ACLs when ignoring schema ACLs
Previous Message Noah Misch 2017-02-05 18:38:35 Re: Ignore tablespace ACLs when ignoring schema ACLs