From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Subject: | Re: ALTER TABLE support for dropping generation expression |
Date: | 2019-12-25 11:01:34 |
Message-ID: | 157727169476.1198.15296771283556567409.pgcf@coridan.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, failed
Spec compliant: not tested
Documentation: tested, passed
Hello
Patch does not apply to master. Could you rebase?
Code looks good and very similar to "ALTER TABLE ... ALTER COLUMN ... DROP IDENTITY"
I noticed one bug:
create table testdrop (i int, b int, m int GENERATED ALWAYS AS ( i*2) stored);
insert into testdrop(i,b) values (3,4);
alter table testdrop alter COLUMN m drop expression ;
alter table testdrop drop column i;
Here is no "m" column anymore. Possible due some forgotten dependency?
regards, Sergei
The new status of this patch is: Waiting on Author
From | Date | Subject | |
---|---|---|---|
Next Message | Marco Slot | 2019-12-25 11:27:57 | Re: Disallow cancellation of waiting for synchronous replication |
Previous Message | Andrey Borodin | 2019-12-25 10:45:23 | Re: Disallow cancellation of waiting for synchronous replication |