Re: Miscalculation in IsCheckpointOnSchedule()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Miscalculation in IsCheckpointOnSchedule()
Date: 2007-11-14 21:15:33
Message-ID: 15711.1195074933@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Surely this makes matters worse, not better. What happens near a segment
>> boundary crossing?

> Here is the dumped progres information by the attached patch
> (only for debug purpose).

Oh, I take that back. I was thinking that conversion of unsigned to
double usually does the Wrong Thing, but in this context it seems to be
the right thing.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Henry B. Hotz 2007-11-14 21:35:51 Re: krb_match_realm
Previous Message Zdenek Kotala 2007-11-14 20:17:10 Re: Fix pg_dump dependency on postgres.h