| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: Strange error in new 003_cic_2pc.pl test |
| Date: | 2021-11-11 16:52:49 |
| Message-ID: | 1570716.1636649569@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrey Borodin <x4mmm(at)yandex-team(dot)ru> writes:
>> That error message is remarkably unhelpful, and I think unnecessarily so.
>> Why the heck isn't XlogReadTwoPhaseData passing on the error string
>> that it just got from XLogReadRecord?
> Noah recently proposed the same [0]. But responders like me started to complain about other places without error reporting around xlog reading.
Ah, I missed that thread. Now that we've seen another instance of the
same failure, I agree it's urgent to get something committed. Noah's
patch matches the style of some other callers, so let's go with that.
(And yeah, why are some of the other callers ignoring errormsg? But
that can wait.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-11-11 17:07:36 | Re: Should AT TIME ZONE be volatile? |
| Previous Message | Andrey Borodin | 2021-11-11 16:20:28 | Re: Strange error in new 003_cic_2pc.pl test |