A modest proposal: let's add PID to assertion failure messages

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: A modest proposal: let's add PID to assertion failure messages
Date: 2020-10-04 21:08:07
Message-ID: 1568983.1601845687@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

In these days when we run almost all test cases in parallel, it's
frequently not that easy to tie a "TRAP: ..." message in the log
to nearby log messages. (The postmaster's subsequent complaint
often helps, but it could be some distance away in the log; and
good luck untangling things if more than one Assert failure happens
concurrently.) We could add a simple bread crumb trail by
including the process's PID in such messages. Any objections?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2020-10-04 21:11:04 Re: Buglets in equivclass.c
Previous Message Tom Lane 2020-10-04 20:20:05 Re: small cleanup: unify scanstr() functions