| From: | Shawn Wang <shawn(dot)wang(at)highgo(dot)ca> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Antonin Houska <ah(at)cybertec(dot)at>, Ants Aasma <ants(dot)aasma(at)eesti(dot)ee> |
| Subject: | Re: WIP: Data at rest encryption |
| Date: | 2019-08-02 06:40:56 |
| Message-ID: | 156472805641.1401.3119816532289012709.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation: not tested
Hi Antonin,
It is very glad to see the new patch. I used the public patches a long time ago.
I did some tests like the stream replication, much data running, temporary files encryption.
I found that there is an issue in the src/backend/storage/file/encryption.c. You should put block_size = EVP_CIPHER_CTX_block_size(ctx); under the #ifdef USE_ASSERT_CHECKING.
There is some problem to merge your patches to the latest kernel in the pg_ctl.c.
Regards,
--
Shawn Wang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adam Lee | 2019-08-02 06:44:05 | Re: Memory-Bounded Hash Aggregation |
| Previous Message | Fabien COELHO | 2019-08-02 06:38:37 | Re: pgbench - implement strict TPC-B benchmark |