| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Make initdb's suggested "pg_ctl start" command line more reliabl |
| Date: | 2016-09-08 16:48:33 |
| Message-ID: | 15621.1473353313@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> More generally, I'm concerned that appendShellString() looks pretty
> attractive for future use. It's not inconceivable that someone will
> want to use it for say calling pg_dump from pg_dumpall or pg_upgrade at
> some point, and then maybe we'll accidentally disallow LF/CR in
> tablespace names, say.
That's fair, but I'm not sure how you propose to avoid it, given that
we don't have a method for safely quoting those characters on Windows.
I would certainly far rather find a way to do that and then remove the
prohibition. But lacking such a solution, we're going to be forced into
messy compromises.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-09-08 17:12:15 | pgsql: Allow pg_dump to dump non-extension members of an extension-owne |
| Previous Message | Peter Eisentraut | 2016-09-08 16:07:35 | Re: Re: [COMMITTERS] pgsql: Make initdb's suggested "pg_ctl start" command line more reliabl |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2016-09-08 16:51:31 | Re: Vacuum: allow usage of more than 1GB of work mem |
| Previous Message | Alvaro Herrera | 2016-09-08 16:47:40 | Re: Default make target in test modules |