Re: [PATCH] remove deprecated v8.2 containment operators

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] remove deprecated v8.2 containment operators
Date: 2020-11-03 09:47:14
Message-ID: 155ecfd8-7ac6-1875-5090-d79a586a8847@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-10-27 04:25, Justin Pryzby wrote:
> Forking this thread:
> https://www.postgresql.org/message-id/fd93f1c5-7818-a02c-01e5-1075ac0d4def@iki.fi
>
> They have been deprecated for a Long Time, so finally remove them for v14.
> Four fewer exclamation marks makes the documentation less exciting, which is a
> good thing.

I have committed the parts that remove the built-in geometry operators
and the related regression test changes.

The changes to the contrib modules appear to be incomplete in some ways.
In cube, hstore, and seg, there are no changes to the extension
scripts to remove the operators. All you're doing is changing the C
code to no longer recognize the strategy, but that doesn't explain what
will happen if the operator is still used. In intarray, by contrast,
you're editing an existing extension script, but that should be done by
an upgrade script instead.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-11-03 10:35:18 Re: Move OpenSSL random under USE_OPENSSL_RANDOM
Previous Message Michael Paquier 2020-11-03 09:46:12 Re: Online checksums verification in the backend