| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Christoph Berg <myon(at)debian(dot)org>, mikael(dot)kjellstrom(at)gmail(dot)com, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Direct I/O |
| Date: | 2023-04-14 19:38:29 |
| Message-ID: | 1557292.1681501109@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2023-04-14 15:21:18 -0400, Tom Lane wrote:
>> +1 for that, though. (Also, the fact that these animals aren't
>> actually failing suggests that 004_io_direct.pl needs expansion.)
> It's skipped, due to lack of O_DIRECT:
> [20:50:22] t/004_io_direct.pl .............. skipped: no O_DIRECT
Hmm, I'd say that might be just luck. Whether the compiler honors weird
alignment of locals seems independent of whether the OS has O_DIRECT.
> So perhaps we don't even need a configure test, just a bit of ifdef'ery? It's
> a bit annoying structurally, because the PG*Aligned structs are defined in
> c.h, but the different ways of spelling O_DIRECT are dealt with in fd.h.
> I wonder if we should try to move those structs to fd.h as well...
I doubt they belong in c.h, so that could be plausible; except
I'm not convinced that testing O_DIRECT is sufficient.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mikael Kjellström | 2023-04-14 19:50:29 | Re: Direct I/O |
| Previous Message | Peter Geoghegan | 2023-04-14 19:37:49 | Re: Temporary tables versus wraparound... again |