| From: | Chapman Flack <chap(at)anastigmatix(dot)net> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: proposal: variadic argument support for least, greatest function |
| Date: | 2019-02-22 00:34:50 |
| Message-ID: | 155079569052.1575.13074606940846336002.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: tested, passed
On 02/21/19 16:04, Tom Lane wrote:
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
>> I wrote doc (just one sentence) and minimal test. Both can be enhanced.
* dutifully submits review saying latest patch passes installcheck-world and has tests and docs, could be RfC
> I still say we should reject this and invent array_greatest/array_least
> functions instead.
* reflects on own pay grade, wanders off in search of other patch to review
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2019-02-22 00:45:54 | RE: Timeout parameters |
| Previous Message | Haribabu Kommi | 2019-02-22 00:33:17 | Removal of duplicate variable declarations in fe-connect.c |