| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Mark Dilger <hornschnorter(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: syscache entries out of order |
| Date: | 2017-05-30 22:48:19 |
| Message-ID: | 15494.1496184499@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
> Just FYI, as of 665d1fad99e7b11678b0d5fa24d2898424243cd6, syscache.h
> entries are not in alphabetical order, which violates the coding standard
> specified in the comment for these entries. In particular, it is the PUBLICATION
> and SUBSCRIPTION entries that are mis-ordered.
Agreed, this is the project convention and we should follow it.
> Sorry for my pedantry. Patch attached.
Patch pushed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2017-05-30 22:50:04 | Re: Use of non-restart-safe storage by temp_tablespaces |
| Previous Message | Thomas Munro | 2017-05-30 22:23:56 | Re: Race conditions with WAL sender PID lookups |