| From: | Mi Tar <mmitar(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: port of INSTALL file generation to XSLT |
| Date: | 2019-01-09 09:05:20 |
| Message-ID: | 154702472013.11631.16924457723314927016.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: tested, failed
Hi!
I tested this. Patch applied cleanly and INSTALL file was produced. Formatting looks differently from before, but I think that it looks better. We lost central alignment of some headings, but many code/command snippets are now better/correctly indented. So I think this is overall better.
Documentation about documentation generation should be updated though. Please add pandoc to requirements here [1].
[1] https://www.postgresql.org/docs/devel/docguide-toolsets.html
Mitar
The new status of this patch is: Waiting on Author
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-01-09 10:21:38 | problems with foreign keys on partitioned tables |
| Previous Message | Dmitry Dolgov | 2019-01-09 09:01:44 | Re: Displaying and dumping of table access methods |