Re: Why does pg_bsd_indent need to be installed?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why does pg_bsd_indent need to be installed?
Date: 2023-05-25 17:05:57
Message-ID: 1543796.1685034357@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2023-05-25 09:09:45 -0400, Tom Lane wrote:
>> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>>> Why does pgindent require that pg_bsd_indent be installed in the path?

> Isn't the situation actually *easier* in VPATH builds? There's no build
> artifacts in the source tree, so you can just invoke the pg_bsd_indent built
> in the build directory against the source tree, without any problems?

Well, if you know where the build directory is, sure. But any way you
slice it there is an extra bit of knowledge required. Since pg_bsd_indent
changes so seldom, keeping it in your PATH is at least as easy as any
other solution, IMO.

Another reason why I like to do it that way is that it supports running
pgindent on files that aren't in the source tree at all, which suits
some old habits of mine.

But, as I said before, I'm open to adding support for other scenarios
as long as we don't remove that one.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2023-05-25 17:08:40 Re: Large files for relations
Previous Message Jacob Champion 2023-05-25 16:54:35 Re: Docs: Encourage strong server verification with SCRAM