Re: Refactor textToQualifiedNameList()

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Subject: Re: Refactor textToQualifiedNameList()
Date: 2018-10-08 15:22:55
Message-ID: 153901217528.1560.4487910098024120064.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation: tested, failed

Hi

I tested this patch. This patch removes some duplicate rows, what is good - on second hand, after this patch, the textToQualifiedNameList does one more copy of input string more. I looked where this function is used, and I don't think so it is a issue.

This patch is trivial - all tests passed and I don't see any problem. I'll mark as ready for commit.

The new status of this patch is: Ready for Committer

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2018-10-08 15:23:48 Re: SCRAM with channel binding downgrade attack
Previous Message Andres Freund 2018-10-08 15:21:56 Re: PostgreSQL 12, JIT defaults