Re: pgsql: Add missing "static" qualifier.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Add missing "static" qualifier.
Date: 2016-02-12 18:19:52
Message-ID: 1538.1455301192@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Feb 12, 2016 at 11:20 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Add missing "static" qualifier.
>>
>> Per buildfarm member pademelon.

> Gah. Sorry I keep missing these.

It's a pain that gcc won't warn about it. On the other hand, it's
probably only neatnik-ism on my part to care; I do not know of any
compilers that would actually give an error. It only seems worth
fixing to me because whether a function is static or not is important
information, so I like functions to be accurately labeled.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-02-12 18:36:21 pgsql: Re-pgindent isolationtester.c.
Previous Message Tom Lane 2016-02-12 18:16:54 Re: Re: [COMMITTERS] pgsql: Add some isolation tests for deadlock detection and resolution.