| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Make SPI_prepare argtypes argument const |
| Date: | 2026-06-11 12:56:50 |
| Message-ID: | 1532419.1781182610@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> This changes the argtypes argument of SPI_prepare(),
> SPI_prepare_cursor(), SPI_cursor_open_with_args(), and
> SPI_execute_with_args() from Oid *argtypes to const Oid *argtypes.
We've discussed that before, and held off because we weren't entirely
sure if anyone would complain that it is an API/ABI break. I think
it's quite likely that the libabigail buildfarm machines will say
it is, but is there any actual consequence?
Also, if we are going to use const in SPI, there are more parameters
besides the datatype OIDs that could stand to be const-ified, eg
the various Datum/isnull arrays.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marcos Pegoraro | 2026-06-11 13:07:37 | Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements |
| Previous Message | vignesh C | 2026-06-11 12:22:50 | Re: Proposal: Conflict log history table for Logical Replication |