Re: [PATCH] Cleanup of GUC units code

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Greg Sabino Mullane <greg(at)turnstep(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Cleanup of GUC units code
Date: 2008-09-08 15:02:45
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> It's good as a joke, but what if the user says '1024b'? Does it mean
>> 1024 blocks or one kilobyte? If blocks, what size are we talking, the
>> usual 512 bytes, or our BLCKSZ?

> For what guc would you find a unit of posix-style "blocks" relevant?!

The point isn't whether it's relevant, the point is that there's a
fairly serious doubt as to what the user thought it meant.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2008-09-08 15:12:23 Common Table Expressions (WITH RECURSIVE) patch
Previous Message Tom Lane 2008-09-08 14:49:18 Re: hash index improving v3