Re: postgres_fdw IMPORT SCHEMA and partitioned tables

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgres_fdw IMPORT SCHEMA and partitioned tables
Date: 2017-03-31 04:51:59
Message-ID: 15303833-838d-079c-2fa2-c01e93771387@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017/03/31 13:46, Michael Paquier wrote:
> On Fri, Mar 31, 2017 at 1:37 PM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> + <para>
>> + For partitioned tables, partitions are automatically excluded from the
>> + schema data imported. Only the definition of partitioned tables is
>> included
>> + to give access to the full data set of all partitions present remotely.
>> + </para>
>> +
>>
>> Only the definitions of "root" partitioned tables, because when using
>> multi-level partitioning, there would be partitioned tables that won't be
>> included (because, relispartition=true).
>>
>> If you agree, then this code comment too could use the same terminology:
>>
>> + * Ignore table data for partitions and only include the parent
>> + * definitions to allow access to the complete remote data set
>> + * locally in the schema imported.
>> + *
>
> That makes sense. Updated this way as I have my hands on it now.

Thanks, no more comments from my side.

Regards,
Amit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-03-31 04:53:12 Re: WIP: [[Parallel] Shared] Hash
Previous Message Craig Ringer 2017-03-31 04:49:59 Re: Logical decoding on standby