Re: [PATCHES] pglister & pgarchives: add deployment tests for gitlab-ci

> 0001 - I'm unsure if we want to hard-code something that relies on an
> external repo like that into the pipelines. But that type of check in
> general can make sense. But what type of errors would you expect it to
> detect?

My script performs a full install, i.e. installing httpd, exim, postgresql, configuring them appropriately and running the django install.
The main point of running this is to check that the django install still works on a fresh install. For instance, this would have automatically detected the issue introduced in 1527758 and fixed in 749be96.
Granted, this can be a bit overkill for the end purpose. We could either reduce it to testing the django install only, or add more tests (e.g. testing test process of subscription, getting messages published etc.)
What do you think?

> 0002 - As I mentioned on the other thread (I think), our primary
> platform is still buster. We shouldn't change the toolchain to
> bookworm until we are ready to do it everywhere, and we are ont yet.
> The part changing it to pycodestyle I think is valid on buster as well
> though?

OK, patch for changing to pycodestyle only attached (it works: https://gitlab.com/cmatte/pglister/-/jobs/5136488484)

> 0003 - This one has already been merged right? It was already
> submitted separately?

Yes, apologies, I ended up sending it in two separate threads

> pgarchives patches:
>
> 0001 - It seems to convert the contents of the files to python3, but
> the shebang still refers python2? I assume that's just an oversight?

Indeed, attached

> 0002 - Same basic comment applies, but also, pgarchives is not
> currently hosted at gitlab, so the gitlab-ci scripts won't do much?

Yes, as stated in the email, the pgarchives repository would need to be moved to gitlab for this to work (why isn't it already, similarly to pglister?)

--
Célestin Matte