Re: [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity.
Date: 2017-01-05 21:33:40
Message-ID: 15257.1483652020@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I suspect you're going to tell me this all needs to be better
> documented, which is probably a valid criticism. Suggestions as to
> where such documentation should be added - either as code comments or
> in a README somewhere or in doc/src/sgml - will be gratefully
> accepted.

Better documentation seems required, but really the whole design seems
rather wacko. Backends must agree on numeric tranche IDs, but every
backend has its own copy of the tranche name? How do we even know what
agreement is? And every one has to "register" every tranche ID for
itself? Why in the world isn't registration done *once* and the tranche
name stored in shared memory?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-01-05 22:02:45 Re: [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity.
Previous Message Robert Haas 2017-01-05 20:02:12 Re: [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-01-05 21:39:34 Re: Re: [BUGS][PATCH] BUG #14486: Inserting and selecting interval have different constraints
Previous Message Tomas Vondra 2017-01-05 20:50:05 Re: Replication/backup defaults