Skip site navigation (1) Skip section navigation (2)

Re: COPY Fillfactor patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: COPY Fillfactor patch
Date: 2005-04-12 13:56:25
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> During recent tuning of the TPC-C workload, I produced the following
> patch to force COPY to leave some space in each data block when it loads
> data into heap relations.

This is an amazingly ugly way to do it.  Put the info into the Relation
structure instead of cluttering heap_insert's API.  (This would mean
that *every* heap_insert is affected, not only COPY, which is what you
want anyway I would think.)

In practice, a real fix for this would add a column to pg_class, in
which case you could get it from the Relation for free.

			regards, tom lane

In response to


pgsql-patches by date

Next:From: Neil ConwayDate: 2005-04-12 14:00:52
Subject: Re: COPY Fillfactor patch
Previous:From: Peter EisentrautDate: 2005-04-12 13:25:22
Subject: Re: OS Locale UTF-8

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group